EVM: respect vm.prank during calls to create #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-xo
commented
Sep 20, 2024
| address usr = address(1312); | ||
| vm.prank(usr); | ||
| target = new Owned(); | ||
| assert(target.owner() == usr); |
There was a problem hiding this comment.
We should check that it changes back afterwards...
blishko
reviewed
Sep 20, 2024
Comment on lines
+841
to
+842
| resetCaller <- use (#config % #resetCaller) | ||
| when (resetCaller) $ assign (#config % #overrideCaller) Nothing |
There was a problem hiding this comment.
Can you explain for me what these two lines do?
|
I think the current state of this PR is that the original issue has been fixed, but the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates our
prankimplementation to match foundrys.prankis now respected during contract creation.Checklist