Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed small numbers parsing #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed small numbers parsing #7

wants to merge 4 commits into from

Conversation

slavafomin
Copy link

@slavafomin slavafomin commented Jun 2, 2022 •
edited
Loading

This PR fixes the issue #6.

Released as: @ton.js/ethjs-unit@0.1.7-beta.1 for testing and a as quick fix.

@slavafomin
Added failed test for small numbers
2e3aa60 
Signed-off-by: Slava Fomin II <slava@fomin.io>
@slavafomin slavafomin mentioned this pull request Jun 2, 2022
Open
2 tasks
@slavafomin
Fixed small numbers parsing
9fe113a 
Signed-off-by: Slava Fomin II <slava@fomin.io>
@slavafomin slavafomin changed the title Added failed toWei() test for small numbers Fixed small numbers parsing Jun 2, 2022
@slavafomin slavafomin marked this pull request as draft June 2, 2022 14:53
@slavafomin
Simplified regex for number trimming
419a7f4 
Signed-off-by: Slava Fomin II <slava@fomin.io>
@slavafomin slavafomin marked this pull request as ready for review June 2, 2022 15:13
@slavafomin slavafomin mentioned this pull request Jun 2, 2022
Closed
@slavafomin slavafomin marked this pull request as draft June 2, 2022 15:42
@slavafomin
Copy link
Author

Solution is pending. Current implementation has some flaws.

@slavafomin
Updated number parsing to use Intl for more reliable results
6aa1692 
Signed-off-by: Slava Fomin II <slava@fomin.io>
@slavafomin
Copy link
Author

I've updated number parsing to use Intl for more reliable results, both toString and toFixed give incorrect results for some numbers.

@slavafomin slavafomin marked this pull request as ready for review June 2, 2022 16:28
@slavafomin
Copy link
Author

Published as @ton.js/ethjs-unit@0.1.7-beta.2 for testing and as a hotfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@slavafomin