-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map editing tools and improved local mapping #92
Draft
victorreijgwart
wants to merge
41
commits into
main
Choose a base branch
from
feature/map_editing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO: Thank you for opening a PR! Please summarize the changes in 1–2 sentences.
This PR should only be reviewed and merged after PR #89.
Type of change
Detailed Summary
TODO: Provide the motivation, context, and links to any related issues, PRs, or documentation:
API Changes
TODO: List any changes to wavemap's APIs to help users update their code. Write "None" if there are no changes.
C++ API:
Python API:
ROS1 Interface:
Review Notes
TODO: Is there anything specific the reviewers should focus on, or are there unresolved questions? Mention them here.
Testing
Automated Tests
TODO: Have you added or modified unit tests to verify these changes? If not, let us know if you'd like assistance.
Manual Tests
TODO: If manual tests were performed to verify these changes, describe them here and include instructions to reproduce them.
Describe test configurations where applicable.
System information (optional):
Runtime information (optional):
For performance or accuracy-related changes, include the above system and runtime information and describe:
Benchmarks (To be completed by maintainers)
TODO: We will rerun wavemap's benchmarks and report the results here to validate there are no general performance/accuracy regressions.
Checklist
General
Documentation (where applicable)