Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mmc room groups DO NOT MERGE - JUST FOR DISCUSSIONS #240

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/docker-build-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- 'main'
- 'mmc-room-groups'
tags:
- 'v[0-9]+.[0-9]+.[0-9]+'

Expand Down Expand Up @@ -41,7 +42,7 @@ jobs:
REGISTRY_USER: ${{ github.actor }}
REGISTRY_PASS: ${{ secrets.GITHUB_TOKEN }}

- name: Docker build and push 'latest' image
- name: Docker build and push 'latest-mmc' image
if: startsWith(github.ref, 'refs/heads/')
run: >
TAG_ARGS=$(echo -n "$IMAGE_TAGS" | sed -r "s_([^ :/]+)_ --tag $REGISTRY/$IMAGE_NAME:\1 _g") &&
Expand All @@ -56,7 +57,7 @@ jobs:
env:
REGISTRY: 'ghcr.io'
IMAGE_NAME: ${{ github.repository }}
IMAGE_TAGS: latest
IMAGE_TAGS: latest-mmc
FULL_REPO_URL: "https://github.com/${{ github.repository }}"
COMMIT_HASH: ${{ github.sha }}

Expand Down
4 changes: 2 additions & 2 deletions src/apis/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ export class LoginRequiredError extends Error {
}
}

export interface ErrorDto<ErrorMessage extends string> {
export interface ErrorDto<ErrorMessageEnum extends string> {
// The time at which the error occurred.
readonly timestamp: string // 2006-01-02T15:04:05+07:00

// An internal trace id assigned to the error. Used to find logs associated with errors across our services. Display to the user as something to communicate to us with inquiries about the error.
readonly requestid: string // a8b7c6d5

// A keyed description of the error. We do not write human-readable text here because the user interface will be multi-language.
readonly message: ErrorMessage // attendee.owned.notfound or similar
readonly message: ErrorMessageEnum // attendee.owned.notfound or similar

// Optional additional details about the error. If available, will usually contain English language technobabble.
readonly details: Readonly<Record<string, readonly string[]>>
Expand Down
Loading
Loading