refactor: simplify cjs/esm build, add initial testing #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry
commented
Sep 14, 2024
| @@ -20,9 +20,7 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| fetch-depth: 0 | |||
| - uses: pnpm/action-setup@v3 | |||
| with: | |||
| version: 8 | |||
There was a problem hiding this comment.
I removed the version here and in other workflows because this action will just read from the packageManager field in package.json, so no need to duplicate this.
Co-authored-by: Tyler Benfield <rtbenfield@gmail.com>
Cherry
changed the title
Cherry
changed the title
|
OMG man.. I was dreading sitting down today with my laptop because I knew I had to wade through this entire mess of ESM/CJS crap trying to get everything to work again.. I owe you more than a few rounds of beer for fixing this next time I am in the UK :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166
Closes #163
Closes #35
This removes the complex build setup here and switches to using
tsupfor quick bundling for dual cjs/esm. Rather than trying to maintain a bespoke solution here with individual CJS/ESM configs and custom build scripts, I figure it'd be easier to use a tried and tested solution in tens of thousands of other projects,It also adds some very basic tests to validate that this can be imported in both CJS and ESM, which should hopefully prevent any regressions in future. I also added the tests @rtbenfield did for DO Storage Instrumentation in #35 to kick off some testing.
These can be extended in future with even more tests of course.
I tested this in a couple of my own projects and it seems to work great, with a much simpler and easier to maintain output, but would appreciate another critical eye.