Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow mermaid visualization in domains #407

Closed
wants to merge 7 commits into from

Conversation

stanipetrosyan
Copy link

Motivation

Resolve issue #376 for create mermaid graph in domains.
Also I refactored graph.ts file introducing Mermaid builder class.

Hope everything is right, let me know if there are issues with my changes.

Have you read the Contributing Guidelines on pull requests?

Yes.

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

⚠️ No Changeset found

Latest commit: a4e4bb0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
eventcatalog-docs ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 9:24am
eventcatalog-example ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 9:24am

@stanipetrosyan
Copy link
Author

Ok, I think is ready. I created new mermaid builder class just for domain case (if we want improve mermaid chart creation in future), leaving the same old logic for events and service. I improved graph test because previously they can failure for different spacing. Let me know if there are issues with my changes.

@boyney123
Copy link
Collaborator

Thank you for the pull request.

V2 is coming out very soon, and things have changed under the hood. And now you can add mermaid code blocks to any resource.

I'm going to close this for now. Ping if you want to keep open and push for a merge....

@boyney123 boyney123 closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants