Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Fix bug 276 by upgrading packages #409

Merged
merged 11 commits into from
Aug 11, 2023

Conversation

pebbz
Copy link

@pebbz pebbz commented Aug 8, 2023

Motivation

Great project and great idea. However, it's difficult to achieve adoption to the project without passing security checks.

yarn audit is currently reporting 190 vulnerabilities on the latest master. By upgrading the packages in question to the latest versions, the vulnerabilities has been reduced to 2

Have you read the Contributing Guidelines on pull requests?

Yes

Changes

Upgraded the following packages:

  • Lerna to latest package which required small change to the configuration file
  • eslint which many of the other packages depended on and required updating some eslint rules
  • jest which required changes to the configuration file.
  • mermaid
  • docusaurus - using latest alpha version which cleans up many of the vulnerabilities
  • svgwebpack
  • tailwindscss

@pebbz pebbz requested a review from boyney123 as a code owner August 8, 2023 17:32
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

🦋 Changeset detected

Latest commit: 919cdc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@eventcatalog/create-eventcatalog Major
@eventcatalog/core Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
eventcatalog-docs ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2023 8:13am
eventcatalog-example ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2023 8:13am

@pebbz pebbz changed the title FIX-276 - Fix bug 276 by upgrading packages chore(core): Fix bug 276 by upgrading packages Aug 8, 2023
@boyney123
Copy link
Collaborator

Thank you @pebbz ! This is great! Will take some time to review/test the upgrades etc, but thanks for this, super helpful

@boyney123 boyney123 merged commit 24634aa into event-catalog:master Aug 11, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Aug 11, 2023
@boyney123
Copy link
Collaborator

@all-contributors add @pebbz for code

@allcontributors
Copy link
Contributor

@boyney123

I've put up a pull request to add @pebbz! 🎉

@boyney123
Copy link
Collaborator

Thank you @pebbz I added you on our contributor list. Thanks for the updates, you can find your changes in 1.0.0! Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants