Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation.md #411

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Update installation.md #411

merged 2 commits into from
Aug 17, 2023

Conversation

aholbreich
Copy link

In fact it generates into /out dir

Motivation

(Write your motivation here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

In fact it generates into /out dir
@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

⚠️ No Changeset found

Latest commit: bc9ed76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
eventcatalog-docs ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2023 9:31am
eventcatalog-example ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2023 9:31am

@aholbreich
Copy link
Author

Hey @boyney123 any actions needed from my side to speed it up?
Happy to contribute more, so trying to stick to your rules and try it make work

@boyney123
Copy link
Collaborator

Thank you @aholbreich just catching up now, looks good to me, thanks for this update!

@boyney123 boyney123 merged commit 32aa984 into event-catalog:master Aug 17, 2023
2 checks passed
@boyney123
Copy link
Collaborator

@all-contributors add @aholbreich for docs

@allcontributors
Copy link
Contributor

@boyney123

I've put up a pull request to add @aholbreich! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants