Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change home redirect status code from permanent to temporary #733

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

dreglad
Copy link
Contributor

@dreglad dreglad commented Aug 25, 2024

This PR suggests making the home redirect temporary (status 302) rather than permanent (301, used by default).

Rationale

The default permanent redirect makes it hard to change the landingPage config setting since browsers tend to cache 301 redirects, well.. permanently. Any future changes may be ignored by the browser, leading to unexpected behavior.

Copy link

changeset-bot bot commented Aug 25, 2024

🦋 Changeset detected

Latest commit: 246f81a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eventcatalog/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@boyney123
Copy link
Collaborator

Thank you @dreglad makes sense to me!

@boyney123 boyney123 merged commit 2d8ef10 into event-catalog:main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants