-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add 404 page #1842
Feat/add 404 page #1842
Conversation
@Babajide777 what with this one? From what I recall we talked about fixing i18n in apps folder etc. |
@evereq alright, i'm on it |
@evereq resolved all issues, the branch passes all checks now |
@Babajide777 what should we do with this one? I think this new page is better than old one, is this PR replacing it and it all works now or something is still broken with i18n for "apps" folder? I still not understand, can (should) we merge this or not? |
@maceteligolden This is still not working for me, is it fixed or need to check? |
@badalkhatri0924 he need your help to fix it, I think @maceteligolden can't make i18n working for "app" router, only for older page router... Can you just make this PR working, remove old 404 page and use new one he built (with working i18n)? |
@badalkhatri0924 I saw offline page, so maybe you can finish this one too? Also, for offline page, maybe you can reuse this same design, just write that text Offlne instead of this 404? |
https://github.com/i18nexus/next-i18n-router/tree/main/examples/i18next-example