Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add 404 page #1842

Merged
merged 13 commits into from
Dec 8, 2023
Merged

Feat/add 404 page #1842

merged 13 commits into from
Dec 8, 2023

Conversation

maceteligolden
Copy link
Contributor

@maceteligolden maceteligolden commented Nov 20, 2023

@evereq evereq marked this pull request as draft November 20, 2023 18:48
@evereq
Copy link
Member

evereq commented Nov 24, 2023

@Babajide777 what with this one? From what I recall we talked about fixing i18n in apps folder etc.
@maceteligolden can you please fix merge conflict for this PR?

@maceteligolden
Copy link
Contributor Author

@evereq alright, i'm on it

@maceteligolden
Copy link
Contributor Author

@evereq resolved all issues, the branch passes all checks now

@evereq
Copy link
Member

evereq commented Nov 27, 2023

@Babajide777 what should we do with this one? I think this new page is better than old one, is this PR replacing it and it all works now or something is still broken with i18n for "apps" folder? I still not understand, can (should) we merge this or not?
CC: @maceteligolden

@badalkhatri0924
Copy link
Contributor

image @maceteligolden This is still not working for me, is it fixed or need to check?

@evereq
Copy link
Member

evereq commented Dec 1, 2023

@badalkhatri0924 he need your help to fix it, I think @maceteligolden can't make i18n working for "app" router, only for older page router... Can you just make this PR working, remove old 404 page and use new one he built (with working i18n)?

@evereq
Copy link
Member

evereq commented Dec 7, 2023

@badalkhatri0924 I saw offline page, so maybe you can finish this one too? Also, for offline page, maybe you can reuse this same design, just write that text Offlne instead of this 404?

@badalkhatri0924 badalkhatri0924 self-assigned this Dec 8, 2023
@badalkhatri0924 badalkhatri0924 added the WEB Web app label Dec 8, 2023
@badalkhatri0924 badalkhatri0924 marked this pull request as ready for review December 8, 2023 13:34
@evereq evereq merged commit b109293 into develop Dec 8, 2023
11 of 12 checks passed
@evereq evereq deleted the feat/add-404-page branch December 8, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WEB Web app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants