-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added operationId to metadata of request specs #131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 96.65% 96.91% +0.26%
==========================================
Files 14 14
Lines 419 422 +3
==========================================
+ Hits 405 409 +4
+ Misses 14 13 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@exoego - What are your thoughts on this feature to enable |
Supporting |
@exoego - Sorry for the confusion here, I was testing out another proposed feature to the gem and committed my change to this PR. I am going to revert my last commit here so that this PR is strictly for the |
aab9d26
to
a05157d
Compare
@exoego - Ok, this PR for adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamerine Could you update any single test to use :operation_id
so we can ensure OpenAPI file generated by tests have operationId
.
@exoego - We added |
@exoego - If we can get this |
Sorry for the late response. |
Added a change to allow users to add operationId to the metadata of request specs. There have been requests to make the OpenAPI spec require operationId for many reasons. Here is an example: OAI/OpenAPI-Specification#1907.
If a user adds
operation-id
to the metadata of a request spec, it will be added to the path section of the schema.First time contributor and I struggled to figure out where to add a test for this feature. Let me know if there is a place where you would like to see a spec for this.