Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add example in menu getting started #1724

Open
wants to merge 7 commits into
base: gh-pages
Choose a base branch
from

Conversation

carlosstenzel
Copy link
Contributor

To improve user experience and streamline navigation, we are introducing a “More Examples” menu item (which already exists in EN) to the menu. This menu item will be available in multiple languages ​​to accommodate our diverse user base.

Initially, all links under the “More Examples” menu item will direct users to an English page. This approach will make it easier to initially aggregate and maintain example content in a centralized location.

By directing to an English page, we can ensure consistency and ease in managing updates, fixes, and enhancements. As the content grows and stabilizes, we may consider localizing these examples into other languages, providing a seamless transition for users.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit ab27114
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/678642d95b54b700083967fc
😎 Deploy Preview https://deploy-preview-1724--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the content of the pages in English, as it was done in #1685, maybe already with the content from #1717, since I'm just waiting for the translation confirmation to merge it

nicolasgandrade added a commit to nicolasgandrade/expressjs.com that referenced this pull request Jan 10, 2025
Please, find the expressjs#1724 PR, where the items for the page are being added to all supported languages.
@carlosstenzel
Copy link
Contributor Author

Please add the content of the pages in English, as it was done in #1685, maybe already with the content from #1717, since I'm just waiting for the translation confirmation to merge it

I'll wait for the merge to make the refresh

bjohansebas pushed a commit that referenced this pull request Jan 13, 2025
…1717)

* fix: replace broken links with new ones and remove references to deleted examples in examples.md

* feat: translate the examples.md page to pt-br

* feat: list the examples page in the header-pt-br.html file

* refactor: remove the more-examples item from the header-pt-br

Please, find the #1724 PR, where the items for the page are being added to all supported languages.

* fix: update the broken urls with correct ones in the indonesian examples page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants