-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ES module option. #316
Open
drjeffjackson
wants to merge
14
commits into
expressjs:master
Choose a base branch
from
drjeffjackson:esm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Apr 4, 2024
-
Add --esm switch that generates a project using ES modules by default.
Configuration menu - View commit details
-
Copy full SHA for ae46832 - Browse repository at this point
Copy the full SHA ae46832View commit details -
Configuration menu - View commit details
-
Copy full SHA for b74e582 - Browse repository at this point
Copy the full SHA b74e582View commit details -
Configuration menu - View commit details
-
Copy full SHA for 066c607 - Browse repository at this point
Copy the full SHA 066c607View commit details -
Eliminate whitespace differences in the generated app.js.
Configuration menu - View commit details
-
Copy full SHA for e9d9dcc - Browse repository at this point
Copy the full SHA e9d9dccView commit details -
Adding testing. Necessitated adding .js extension to generated bin/www filename.
Configuration menu - View commit details
-
Copy full SHA for 967aae2 - Browse repository at this point
Copy the full SHA 967aae2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20a2a7d - Browse repository at this point
Copy the full SHA 20a2a7dView commit details
Commits on Apr 5, 2024
-
Exit if --esm switch is not supported
Modify the --esm switch processing to error out of the generator if the Node version is less than 14. Update documentation and testing to reflect this change.
Configuration menu - View commit details
-
Copy full SHA for 1a70274 - Browse repository at this point
Copy the full SHA 1a70274View commit details
Commits on Apr 6, 2024
-
Fix esm 'should export an express app from app.js; test failures for early Node versions by moving import into a call to eval(). Also correct two errors in this test and include error handling. In addition, update all generated code when --esm is active to use const rather than var and arrow syntax rather than function expression syntax for callbacks.
Configuration menu - View commit details
-
Copy full SHA for 5f3c3c0 - Browse repository at this point
Copy the full SHA 5f3c3c0View commit details
Commits on Apr 7, 2024
-
Change switch from esm to es6 to better reflect what the switch does.
Configuration menu - View commit details
-
Copy full SHA for ee6cc50 - Browse repository at this point
Copy the full SHA ee6cc50View commit details
Commits on Apr 8, 2024
-
parallel templates, .mjs, fix "should export" test
Use parallel template files for non-es6 and es6 versions of app and www. In es6 mode, use .mjs extension on all generated JavaScript files. Remove node: in the es6 "should export" test's require of url.
Configuration menu - View commit details
-
Copy full SHA for 9c3a1fb - Browse repository at this point
Copy the full SHA 9c3a1fbView commit details
Commits on Apr 9, 2024
-
The type field is now added to package.json only when the generator is run with the --es6 switch.
Configuration menu - View commit details
-
Copy full SHA for ed2910b - Browse repository at this point
Copy the full SHA ed2910bView commit details
Commits on Apr 10, 2024
-
Remove node: from generated files
The node: URL scheme was not available in v14 until v14.13.1. So, removing this scheme to stay compatible with all releases of v14.
Configuration menu - View commit details
-
Copy full SHA for 462d202 - Browse repository at this point
Copy the full SHA 462d202View commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8c122a2 - Browse repository at this point
Copy the full SHA 8c122a2View commit details -
Group Node imports at top of files.
Per recommendation by aagamezl.
Configuration menu - View commit details
-
Copy full SHA for a225474 - Browse repository at this point
Copy the full SHA a225474View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.