Load global storage object in a lazy manner #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community guidelines:
contributing guidelines
and
code of conduct
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
The global
storageobject is loaded eagerly, as a result it's evaluated as a side effect whenever the package is loaded, even when just pure functions (e.g.getBucket) are imported/used. It is quite unexpected from user's perspective and makes testing troublesome (e,g. testing the UI part of an extension in non extension environment always fails simply because@extend-chrome/storageis loaded to the bundle)P.S. There's no system test setup in the repo to test these sort of problems, hence no extra tests added.