Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OTP 23 support with swappable native or Rust NIF keccack hash implementation #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rupurt
Copy link

@rupurt rupurt commented Oct 18, 2020

- keccakf1600 doesn't compile on Erlang OTP 23
(potatosalad/erlang-keccakf1600#5)
@rupurt rupurt changed the title Use native or Rust NIF for keccack hash Enable OTP 23 support with swappable native or Rust NIF keccack hash implementation Oct 18, 2020
@ayrat555
Copy link
Member

@rupurt I fixed this in https://github.com/poanetwork/ex_abi

@rupurt
Copy link
Author

rupurt commented Oct 19, 2020

@ayrat555 awesome, thank you. Have you tried to upstream it to the dependent libraries?

@ayrat555
Copy link
Member

No, but I think that's a good idea. I see only two libraries on hex.pm that depend on this version of abi implementation. it should just work (the only difficulty will be adding rust).

Btw, ex_abi is more stable and there are no known bugs there.

@rupurt
Copy link
Author

rupurt commented Oct 19, 2020

Sweet. This was the lib I was trying to use when I ran into the underlying problem https://github.com/hswick/exw3.

BTW cool to meet you @ayrat555 👋. Nice to see there is an active Elixir developer in the blockchain space 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants