Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(once_cell): remove dependency on once_cell #1181

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

erwinvaneijk
Copy link
Contributor

Rust 1.80 has a proper implementation of LazyLock, which, when used, removes the dependency on once_cell.

  • update toolchain to 1.80.0 from 1.70.0
  • remove once_cell from dependencies

Fixes: #1169

Rust 1.80 has a proper implementation of LazyLock, which, when used,
removes the dependency on once_cell.

- update toolchain to 1.80.0 from 1.70.0
- remove once_cell from dependencies

Fixes: eza-community#1169
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update toolchain to 1.80.0 from 1.70.0

I'm not sure we can just do that this easily, we need to ensure that it still supports most distros, specially debian tends to be quite slow here.

@erwinvaneijk
Copy link
Contributor Author

update toolchain to 1.80.0 from 1.70.0

I'm not sure we can just do that this easily, we need to ensure that it still supports most distros, specially debian tends to be quite slow here.

Agreed, but I figured it would be convenient to see where things would break down if the migration actually should happen.

- these tests rely on the way a panic is formatted, which changed from
  rustc 1.70 to 1.80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

once_cell crate still needed?
2 participants