Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove special case for _ prefixed files in windows #1233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jschpp
Copy link
Contributor

@jschpp jschpp commented Nov 14, 2024

On windows files prefixed with a _ were being ignored because some old applications used those files as pseudo dotfiles.

This was controversial when the feature was added way back when: ogham/exa#820 (review)

Fixes #1220

On windows files prefixed with a `_` were being ignored because some old
applications used those files as pseudo dotfiles.

This was controversial when the feature was added way back when:
ogham/exa#820 (review)

Fixes eza-community#1220
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need some discussion before being implemented

@jschpp
Copy link
Contributor Author

jschpp commented Nov 14, 2024

Yeah. I completely agree with you there.
I'm not sure if removing is the right way to go forward here myself.
I tried hiding this behind a cmd flag but couldn't quite get it to work since I'd need to add something like git_ignoring which will have to be included pretty much everywhere since it would touch the Files API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

bug: eza hides files beginning with __ for python projects on Windows
2 participants