develop apha parser #840
develop apha parser #840
Conversation
apha/parser.js
Outdated
| // https://pharmacylibrary.com/doi/epub/10.21019/9781582122861 | ||
| result.rtype = 'BOOK'; | ||
| result.mime = 'EPUB'; | ||
| result.doi = `${match[1]}/${match[2]}`; |
There was a problem hiding this comment.
This is not a valid DOI, I have tried it on https://www.doi.org
it looks more like a DOI prefix and an ISBN. match[2] as ISBN.
I don't get the impression that this platform offers the full DOI in its URLs. Unlucky.
There was a problem hiding this comment.
Hi @felixleo22
Sure. I removed the doi. Please check again.
apha/parser.js
Outdated
| // https://pharmacylibrary.com/doi/epdf/10.21019/9781582121444 | ||
| result.rtype = 'BOOK'; | ||
| result.mime = 'PDF'; | ||
| result.doi = `${match[1]}/${match[2]}`; |
There was a problem hiding this comment.
DOI is not valid : match[2] as ISBN.
There was a problem hiding this comment.
Sure. I removed doi.
chaoyinYang
temporarily deployed
to
development
GitHub Actions
Inactive
chaoyinYang
temporarily deployed
to
development
GitHub Actions
Inactive
|
My bad, now these DOI are recognised by https://www.doi.org. I don't know why it wasn't valid at the time, perhaps I made a typing error. You can apply the old commit and I will merge this PR. |
|
I'm going to merge this PR, but I'm going to add the DOI to the parser, so don't forget to pull the repository to get my changes. |
No description provided.