Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-6221: removed duplicate conditions from isFieldEmpty visitor #245

Open
wants to merge 1 commit into
base: 3.3
Choose a base branch
from

Conversation

reithor
Copy link
Contributor

@reithor reithor commented Jul 24, 2023

https://issues.ibexa.co/browse/IBX-6221

Removes duplicate sql conditions from FieldEmpty->visit
(does not affect query result but shortens query that is send to solr)

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@reithor reithor marked this pull request as ready for review July 25, 2023 10:05
@reithor reithor requested review from Steveb-p, alongosz and a team July 25, 2023 10:05
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

We need some basic unit test coverage for that use case, specifically for that FieldEmpty Visitor, showcasing the bug. The test should create a Criterion which caused duplication and check if the output is as expected.

So, expecting to see new tests/Query/Common/CriterionVisitor/Field/FieldEmptyTest.php :)
Please cover just the essence of the bug - I know we could do much more there but that's on us - maintainers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants