토스 페이먼츠 결제 승인 로직 전의 주문 승인 로직 추가 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
기본적으로는 Merge는 리뷰를 받은 다음에 해야하고, 다른 사람의 리뷰가 늦는 경우 Merge하는 대신 해당 시점에서 새로운 commit/branch로 작업하고 pull request를 추가로 남깁니다. Merge가 master merge인 경우 지양해야하지만, 개인 branch merge는 상관없겠죠? |
f-lab-TJ
approved these changes
Jul 8, 2023
daadaadaah
force-pushed
the
feat/add-approveOrder
branch
from
5407490
to
f39d101
Compare
daadaadaah
force-pushed
the
feat/add-approveOrder
branch
from
f39d101
to
7e8e479
Compare
daadaadaah
commented
Jul 8, 2023
Comment on lines
+100
to
+103
| * | ||
| * realOrderQuantity 이 필요한 이유는 "부분 주문" 때문이다. | ||
| * 재고량이 0은 아니지만, 사용자가 주문한 수량에 비해 재고량이 없는 경우가 있다. | ||
| * 이때, 재고량만큼만 주문하도록 할 수 있도록 "부문 주문"이 가능한데, 사용자가 주문한 수량과 혼동되지 않도록 실제 주문하는 수량이라는 의미를 내포하기 위해서 필요하다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Comment