InventoryCommandRepository에 amount 양수 검증 추가
#138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
네, null이나 empty 체크는 기본으로 해주는게 좋을 것 같습니다. |
f-lab-TJ
reviewed
Jul 15, 2023
| String key = super.getRedisKey(dealProductUuid); | ||
|
|
||
| return (int) redisStringsRepository.decreaseByAmount(key, Long.valueOf(amount)); | ||
| } | ||
|
|
||
| public void increaseByAmount(UUID dealProductUuid, int amount) { | ||
| validationAmountIsPositive(amount); | ||
|
|
||
| String key = super.getRedisKey(dealProductUuid); | ||
|
|
||
| redisStringsRepository.increaseByAmount(key, Long.valueOf(amount)); |
There was a problem hiding this comment.
decrease가 감소 후 값을 반환해준다면 increase도 동일한 패턴으로 가는게 좋지않을까요?
There was a problem hiding this comment.
재고 사후 검증 때문에 decrease는 return 값을 해주었는데, return 값을 사용하지 않아도 return 해주는게 좋을까요?
redis client에서도 @f-lab-TJ 코멘트처럼 둘다 return 값을 주긴합니다!ㅎㅎ
There was a problem hiding this comment.
나중에 이 코드를 사용하는 사람이 덜 헷갈리는게 어떤 것일지, 정보의 소멸이 장점일지 단점일지 (Redis는 리턴 값을 줬으나 내 API는 생략하는 경우) 고민해보면 좋을 것 같아요
There was a problem hiding this comment.
#154 따로 PR 만들어서 수정했습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
InventoryCommandRepository추가 #56 (comment)Comment
getMany에서Set<String> uuidStrings의 사이즈가 0일 때예요!