-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InventoryCommandRepository
추가
#56
Merged
daadaadaah
merged 3 commits into
f-lab-edu:develop
from
daadaadaah:feat/add-InventoryCommandRepository
Jun 26, 2023
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
src/main/java/com/hcommerce/heecommerce/inventory/InventoryCommandRepository.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package com.hcommerce.heecommerce.inventory; | ||
|
||
import com.hcommerce.heecommerce.common.dao.RedisStringsRepository; | ||
import org.springframework.beans.factory.annotation.Autowired; | ||
import org.springframework.stereotype.Repository; | ||
|
||
@Repository | ||
public class InventoryCommandRepository { | ||
|
||
private final RedisStringsRepository redisStringsRepository; | ||
daadaadaah marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
@Autowired | ||
public InventoryCommandRepository( | ||
RedisStringsRepository redisStringsRepository | ||
) { | ||
this.redisStringsRepository = redisStringsRepository; | ||
} | ||
|
||
public void set(String key, int amount) { | ||
redisStringsRepository.set(key, String.valueOf(amount)); | ||
} | ||
|
||
public void delete(String key) { | ||
redisStringsRepository.delete(key); | ||
} | ||
|
||
public int decreaseByAmount(String key, int amount) { | ||
return (int) redisStringsRepository.decreaseByAmount(key, Long.valueOf(amount)); | ||
} | ||
|
||
public void increaseByAmount(String key, int amount) { | ||
redisStringsRepository.increaseByAmount(key, Long.valueOf(amount)); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,40 @@ | ||
# database | ||
spring.datasource.url= | ||
spring.datasource.username= | ||
spring.datasource.password= | ||
spring.datasource.driver-class-name= | ||
spring.datasource.url=jdbc:mysql://${MYSQL_HOST:localhost}:3306/hee_commerce | ||
spring.datasource.username=root | ||
spring.datasource.password=test1234 | ||
spring.datasource.driver-class-name=com.mysql.cj.jdbc.Driver | ||
|
||
# devtools | ||
# dev tools | ||
spring.devtools.restart.poll-interval= | ||
spring.devtools.restart.quiet-period= | ||
|
||
# Redis | ||
spring.redis.host=localhost | ||
spring.redis.port=6379 | ||
|
||
# sqs | ||
spring.cloud.aws.sqs.endpoint= | ||
spring.cloud.aws.sqs.pr.input.name=MyQ.fifo | ||
spring.cloud.aws.sqs.nm.output.name=MyQ.fifo | ||
|
||
spring.jackson.serialization.indent_output=true | ||
management.endpoint.health.show-details=always | ||
management.endpoints.web.exposure.include=* | ||
|
||
spring.cloud.aws.sqs.listener.max-inflight-messages-per-queue=50 | ||
spring.cloud.aws.sqs.listener.max-concurrent-messages=50 | ||
spring.cloud.aws.sqs.listener.max-messages-per-poll=10 | ||
spring.cloud.aws.sqs.listener.poll-timeout=PT10S | ||
spring.cloud.aws.sqs.listener.max-delay-between-polls=PT10S | ||
spring.cloud.aws.region.static=us-east-1 | ||
spring.cloud.aws.credentials.access-key= | ||
spring.cloud.aws.credentials.secret-key= | ||
|
||
#MyBatis | ||
mybatis.type-aliases-package=com.hcommerce.heecommerce | ||
mybatis.configuration.map-underscore-to-camel-case=true | ||
logging.level.com.hcommerce.heecommerce.*.mapper=trace | ||
# logging.level.com.hcommerce.heecommerce=trace | ||
|
||
# resources/mapper 를 포함한 그 하위 폴더에 있는 XML을 XML 매핑 파일로 인식한다. 프로덕션 코드 뿐만 아니라 테스트 properties에도 해줘야 함 | ||
mybatis.mapper-locations=classpath:mappers/**/*.xml |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InventoryCommandRepository와 InventoryQueryRepository를 따로 나눈 이유는 뭘까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다른 도메인 처럼 쓰기와 읽기 책임을 나눔으로써 단일 책임 원칙을 준수하고 싶었고, 다른 도메인과 일관성을 맞추고 싶어서 따로 나눴습니다.
현재 기획에서 재고라는 도메인이 조회 / 추가, 증가, 감소, 삭제만 있지만, 추후에 타임딜 상품들 재고 조회, 전체 상품 재고 조회 등 조회 뿐만 아니라 추가/삭제도 다양한 방식의 추가 등 다양한 요구사항이 발생할 수 있을 거라고 생각해서, 확장성을 고려해 관심사 분리를 하면, 유지보수가 더 쉽지 않을까 생각했습니다.