Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InventoryCommandRepository 추가 #56

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ dependencies {
implementation 'org.springframework.boot:spring-boot-starter-validation'
implementation 'mysql:mysql-connector-java:8.0.22'
implementation 'org.springframework.boot:spring-boot-starter-data-redis'
implementation 'org.redisson:redisson-spring-boot-starter:3.21.3'
implementation 'org.flywaydb:flyway-core'
implementation 'org.flywaydb:flyway-mysql'
developmentOnly 'org.springframework.boot:spring-boot-devtools'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,8 @@ public long decreaseByAmount(String key, long amount) {
public long increaseByAmount(String key, long amount) {
return redisTemplate.opsForValue().increment(key, amount); // 증가시킨 후의 결과값이 return된다.
}

public void delete(String key) {
redisTemplate.delete(key);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
package com.hcommerce.heecommerce.inventory;

import com.hcommerce.heecommerce.common.dao.RedisStringsRepository;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Repository;

@Repository
public class InventoryCommandRepository {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InventoryCommandRepository와 InventoryQueryRepository를 따로 나눈 이유는 뭘까요?

Copy link
Collaborator Author

@daadaadaah daadaadaah Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 도메인 처럼 쓰기와 읽기 책임을 나눔으로써 단일 책임 원칙을 준수하고 싶었고, 다른 도메인과 일관성을 맞추고 싶어서 따로 나눴습니다.
현재 기획에서 재고라는 도메인이 조회 / 추가, 증가, 감소, 삭제만 있지만, 추후에 타임딜 상품들 재고 조회, 전체 상품 재고 조회 등 조회 뿐만 아니라 추가/삭제도 다양한 방식의 추가 등 다양한 요구사항이 발생할 수 있을 거라고 생각해서, 확장성을 고려해 관심사 분리를 하면, 유지보수가 더 쉽지 않을까 생각했습니다.


private final RedisStringsRepository redisStringsRepository;
daadaadaah marked this conversation as resolved.
Show resolved Hide resolved

@Autowired
public InventoryCommandRepository(
RedisStringsRepository redisStringsRepository
) {
this.redisStringsRepository = redisStringsRepository;
}

public void set(String key, int amount) {
redisStringsRepository.set(key, String.valueOf(amount));
}

public void delete(String key) {
redisStringsRepository.delete(key);
}

public int decreaseByAmount(String key, int amount) {
return (int) redisStringsRepository.decreaseByAmount(key, Long.valueOf(amount));
}

public void increaseByAmount(String key, int amount) {
redisStringsRepository.increaseByAmount(key, Long.valueOf(amount));
}
}
37 changes: 32 additions & 5 deletions src/main/resources/application-dev.properties
Original file line number Diff line number Diff line change
@@ -1,13 +1,40 @@
# database
spring.datasource.url=
spring.datasource.username=
spring.datasource.password=
spring.datasource.driver-class-name=
spring.datasource.url=jdbc:mysql://${MYSQL_HOST:localhost}:3306/hee_commerce
spring.datasource.username=root
spring.datasource.password=test1234
spring.datasource.driver-class-name=com.mysql.cj.jdbc.Driver

# devtools
# dev tools
spring.devtools.restart.poll-interval=
spring.devtools.restart.quiet-period=

# Redis
spring.redis.host=localhost
spring.redis.port=6379

# sqs
spring.cloud.aws.sqs.endpoint=
spring.cloud.aws.sqs.pr.input.name=MyQ.fifo
spring.cloud.aws.sqs.nm.output.name=MyQ.fifo

spring.jackson.serialization.indent_output=true
management.endpoint.health.show-details=always
management.endpoints.web.exposure.include=*

spring.cloud.aws.sqs.listener.max-inflight-messages-per-queue=50
spring.cloud.aws.sqs.listener.max-concurrent-messages=50
spring.cloud.aws.sqs.listener.max-messages-per-poll=10
spring.cloud.aws.sqs.listener.poll-timeout=PT10S
spring.cloud.aws.sqs.listener.max-delay-between-polls=PT10S
spring.cloud.aws.region.static=us-east-1
spring.cloud.aws.credentials.access-key=
spring.cloud.aws.credentials.secret-key=

#MyBatis
mybatis.type-aliases-package=com.hcommerce.heecommerce
mybatis.configuration.map-underscore-to-camel-case=true
logging.level.com.hcommerce.heecommerce.*.mapper=trace
# logging.level.com.hcommerce.heecommerce=trace

# resources/mapper 를 포함한 그 하위 폴더에 있는 XML을 XML 매핑 파일로 인식한다. 프로덕션 코드 뿐만 아니라 테스트 properties에도 해줘야 함
mybatis.mapper-locations=classpath:mappers/**/*.xml