[보류] [OrderService의 placeOrder] AWS SQS로 주문내역 보내기 기능 추가
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daadaadaah
changed the title
OrderService의 placeOrder] AWS SQS로 주문내역 보내기 기능 추가
|
SQS를 왜 사용하는건가요? 현재 저희가 구현하는 것들의 workflow 중에 동기방식으로 해결이 안되는 케이스가 무엇인가요? |
f-lab-TJ
reviewed
Jun 23, 2023
| public void sendMessage(String message) { | ||
| if (message == null) { | ||
| final String errorMessage = "empty message"; | ||
| throw new RuntimeException(errorMessage); |
There was a problem hiding this comment.
이거 사용자 정의 예외 만들어서 수정해보겠습니다!
|
|
주문 API 수정 후 ReOpen 할지 판단하기 |
daadaadaah
changed the title
OrderService의 placeOrder] AWS SQS로 주문내역 보내기 기능 추가OrderService의 placeOrder] AWS SQS로 주문내역 보내기 기능 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Comment
OrderService의placeOrder] 재고 관련 로직 추가 #55 에 같이 넣으면 리뷰하기 불편하실 것 같아서 따로 PR 만들었어요!OrderService의placeOrder] 재고 관련 로직 추가 #55 Merge 되면 branch를 develop 변경해서 Merge 시킬 예정입니다.