[보류] placeOrder의 orderForm 유효성 검증 중 validateOrderQuantityInMaxOrderQuantityPerOrder 추가
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daadaadaah
changed the title
placeOrder의 유효성 검증 중 validateOrderQuantityInMaxOrderQuantityPerOrder 추가placeOrder의 orderForm 유효성 검증 중 validateOrderQuantityInMaxOrderQuantityPerOrder 추가
daadaadaah
force-pushed
the
feat/add-validateOrderQuantityInMaxOrderQuantityPerOrder-in-placeOrder
branch
from
b1e3887
to
86f98da
Compare
daadaadaah
commented
Jun 24, 2023
| private final String productMainImgThumbnailUrl; | ||
| private final DealProductStatus dealProductStatus; | ||
| private final int maxOrderQuantityPerOrder; |
There was a problem hiding this comment.
@builder 를 사용하면, 이렇게 새로운 필드가 추가될 때, 컴파일 에러가 발생하지 않아, 어디를 수정해야할지 일일이 찾아야 하는 번거로움이 있는데, 이 번거로움을 해소할 만한 방법 같은 걸 찾아보려면 어떤 키워드로 검색해보는게 좋을까요? 🤔
|
주문 API 로직 수정 후 다시 Open할지 판단하기 |
daadaadaah
changed the title
placeOrder의 orderForm 유효성 검증 중 validateOrderQuantityInMaxOrderQuantityPerOrder 추가placeOrder의 orderForm 유효성 검증 중 validateOrderQuantityInMaxOrderQuantityPerOrder 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Comment
placeOrder의orderForm유효성 검증 중validateHasDealProductUuid추가 #69 이 PR Merge 되면 base branch를 develop으로 변경해서 Merge 시킬게요~