Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#23] 컨테이너 기반 실행을 위해 Docker 도입 #25

Merged
merged 4 commits into from
Jun 6, 2024
Merged

[#23] 컨테이너 기반 실행을 위해 Docker 도입 #25

merged 4 commits into from
Jun 6, 2024

Conversation

hyeok-kong
Copy link
Collaborator

구현 기능

  • 각 마이크로서비스 별 이미지 생성을 위한 Dockerfile
  • 데이터베이스 변경 ( localhost h2 -> ncp server mysql )
  • docker compose 파일 구현

개발 코멘트

  • 하나의 인스턴스에서 작업하기에 docker-compose를 통해 모든 마이크로서비스를 관리합니다.

@hyeok-kong hyeok-kong added the infra docker, ci/cd, etc.. label Jun 5, 2024
@hyeok-kong hyeok-kong self-assigned this Jun 5, 2024
f-lab-troy
f-lab-troy approved these changes Jun 6, 2024
View reviewed changes
eureka-discovery/Dockerfile
WORKDIR /workspace/app

# JAR 파일 복사
COPY ./build/libs/eureka-discovery-0.0.1-SNAPSHOT.jar /workspace/app/eureka-discovery.jar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COPY문을 여러번 쓰는 것 vs 한줄에 쓰는 것에 대한 차이를 조사해보시면 좋습니다.

@hyeok-kong hyeok-kong merged commit de69f7c into main Jun 6, 2024
1 check passed
@hyeok-kong hyeok-kong linked an issue Jun 6, 2024 that may be closed by this pull request
도커 이미지 생성 #23
Closed
@hyeok-kong hyeok-kong deleted the feature/23 branch June 6, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-troy f-lab-troy f-lab-troy approved these changes

Assignees

@hyeok-kong hyeok-kong

Labels
infra docker, ci/cd, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

도커 이미지 생성
2 participants
@hyeok-kong @f-lab-troy