[#54] 카프카를 통한 이벤트 기반 통신 구현 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeok-kong
commented
Jul 27, 2024
|
|
||
| public class EventConstants { | ||
|
|
||
| public static final String GROUP_MEMBER_INCREASE_REQUEST = "dev.group.payment.request.increase-group-size"; |
There was a problem hiding this comment.
상수를 통해 카프카 토픽을 관리함으로써 human error 를 방지합니다.
hyeok-kong
commented
Jul 27, 2024
| */ | ||
| @Modifying | ||
| @Query("update Group g set g.groupSize = :groupSize where g.id = :id") | ||
| void updateGroupSize(@Param("id") Long id, @Param("groupSize") Integer groupSize); |
There was a problem hiding this comment.
해당 메소드는 동시성 문제 발생 가능성이 있습니다.
update 기능은 JPA 의 Dirty Checking 을 통해서도 구현 가능하지만, entity에서 해당 기능을 호출할 수 있으므로 실수를 범할 가능성이 크다고 생각했습니다.
이에 동시성 문제가 발생할 수 있는 command 를 Repository 로 분리하는 방법을 사용해보았습니다.
|
두 마이크로서비스에서 공통적으로 사용되는 로직들이 다수 존재합니다. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개발 내용
payment-service와 통신결제 요청->결제 완료->그룹 인원 증가흐름 구현개발 코멘트
common-library로 추출해야 합니다.