Feature/admin concert place #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinspark-lab
approved these changes
Sep 22, 2024
| public ResponseEntity<ResponseDto<String>> customException(CustomException exception) { | ||
| ResponseDto<String> responseDto = new ResponseDto<>(exception.getStatus().toString(), | ||
| exception.getMessage()); | ||
| log.warn("CustomRuntimeException 발생 : code: {}, message: {}", responseDto.getCode(), responseDto.getBody()); |
| public ResponseEntity<ResponseDto<String>> customException(MethodArgumentNotValidException exception) { | ||
| HttpStatus badRequest = HttpStatus.BAD_REQUEST; | ||
| ResponseDto<String> responseDto = new ResponseDto<>(badRequest.toString(), "요청 값이 잘 못 됐습니다"); | ||
| log.warn("MethodArgumentNotValidException 발생 : message: {}", exception.getMessage()); |
| public class Place { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; |
There was a problem hiding this comment.
기존 장소에 대한 수정이 들어가는 경우 Update 로 하실 거인거죠?
| }) | ||
| @DynamicInsert | ||
| @EntityListeners(AuditingEntityListener.class) | ||
| public class PlaceVersion { |
| .address(address) | ||
| .identifier(identifier) | ||
| .version(beforePlace.getNextVersion()) | ||
| .last(true) |
There was a problem hiding this comment.
get 에서 last 를 셋팅하는 write operation 이 같이 있는데요. 분리하면 좋을 것 같습니다.
함수는 getNextPlace 로 DB 변경이 없을 것이 기대되지만 실재로는 beforePlace 의 last 가 Update 되는 함수라 안정적이지 않아보입니다.
차라리 last 를 별도 루틴에서 셋팅하게해서 read / write 를 분리하는게 좋을것 같습니다.
| public Place getLastVersion(String identifier) { | ||
| return placeRepository.findTopByIdentifierOrderByVersionDesc(identifier) | ||
| .orElseThrow(() -> new ResourceNotFoundException("place", identifier)); | ||
| } |
There was a problem hiding this comment.
사소한 부분이지만 나중에는 Service 레벨에서는 Entity 를 직접 다루기 보다 VO 를 사용하는 연습해보시면 좋을것 같습니다.
|
jinspark-lab
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
관리자 관련 장소 API 개발
상세정보