feat: make query_command shell-agnostic
#19
Conversation
`query_command` is now of type `table` so that `vim.fn.jobstart` does not use `shell`.
bugabinga
changed the title
query_command shell-agnosticquery_command shell-agnostic
lua/auto-dark-mode/init.lua
Outdated
| else | ||
| return | ||
| end | ||
|
|
||
| if vim.fn.has("unix") ~= 0 then | ||
| if vim.loop.getuid() == 0 then | ||
| query_command = "su - $SUDO_USER -c " .. query_command | ||
| query_command = vim.tbl_extend("keep", { "su", "-", "$SUDO_USER", "-c" }, query_command) |
There was a problem hiding this comment.
I'm unsure how this command will behave now.
It seems like su will spawn the default shell indicated in /etc/passwd?
|
Hey @nekowinston! Does your commit fix the issues with the PR? Feel free to merge this if it works for you or close it otherwise :) |
|
It doesn't, my commit so far was a simple syntax error fix, the whole PR doesn't work for me in its current state. |
|
No worries, do as you wish whenever you wish with this one :) |
|
I have tested this branch on Windows, WSL and Fedora 40 and those work. |
this should help with escalation methods that aren't sudo, we don't have to add support for them right now, but at least alert the user that an error occurred.
|
Sorry for taking ages to get to this! 😓 As an aside, I've also started to use nushell exclusively on my system, so this PR is much appreciated. |
nekowinston
changed the title
query_command shell-agnosticquery_command shell-agnostic
fixes #18
query_commandis now of typetableso thatvim.fn.jobstartdoesnot use
shell.Tested on Windows 11 with nushell.
Needs testing in:
The code in
parse_query_responsenow needs to handle a table, instead of a string, because thequery_commandcannot use pipes any more, which previously guaranteed that stdout consisted of one line.