feat: use new neovim apis, add :healthcheck, fix sudo query_command
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `vim.uv` over `vim.loop`, `vim.system` over `vim.fn.jobstart`, adds a `:checkhealth` hook with a query_command benchmark, and fixes the `SUDO_USER` query_command.
…r various refactor
|
I still need to check if this works on neovim 0.8 and neovim 0.9, but support for 0.10 should work fine already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
vim.uvovervim.loop,vim.systemovervim.fn.jobstart, adds a:checkhealthhook with a query_command benchmark, and fixes theSUDO_USERquery_command. Still preserves fallbacks for jobstart & vim.loop so it will work on older neovim versions.Also uses
vim.validateto validate the plugin options and refactors quite a bit; moving the query/interval logic into its own lua module.It's still a bit of a mess right now but I figured I'd open the PR sooner rather than later.
Fixes #33.
Fixes #34.