-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-config-react-app): support ESLint 8.x #11375
Conversation
Any timeline for this getting fixed/merged now that eslint v8 is live? |
808bcc7
to
c14e787
Compare
@ahummel25 As you can see in the OP, not all dependencies are updated for ESLint 8.x (yet), so we'll have to wait for them first. |
7fe5a3f
to
08bcdaa
Compare
@MichaelDeBoey should jest-community/eslint-plugin-jest#940 be added to the This was released in a minor ( |
a96f551
to
03dc310
Compare
Friendly ping: I think everything is merged now! |
@ianldgs I'll update the PR whenever I have some time 👍 |
03dc310
to
2bb887e
Compare
Any update on when we plan to merge/release this? |
@MichaelDeBoey seems like some tests are still failing - I could not find any relations in the eslint release notes but we could try to update to 8.3.0 and see if that fixes anything - if not we'll have to take a closer look cc. @iansu @mrmckeb |
Actually the main branch seems to be failing in node 16/mac os on the same test "uses yarn as the package manager" - Will have to investigate |
@MichaelDeBoey, this is great - thanks. We'd like to merge this in, but it looks like there are some dependency updates. If you can take a look, that would be great. Otherwise I can jump in and help! It might also be worth bumping to ESLint 8.3.0 (and spot check the other versions). |
Tests should be fixed on main now 🤞 |
@MichaelDeBoey rebased and updated branch here: https://github.com/umati/create-react-app/tree/eslint-8 please integrate if you like. |
BREAKING CHANGE: Requires ESLint@^8.0.0
2bb887e
to
5157757
Compare
@mrmckeb I've rebase this onto |
ESLint v8.0.0 is released 🎉
Dependencies should be compatible with ESLint 8 too before we can merge this one:
@babel/eslint-parser
(Support ESLint 8.x babel/babel#13712)@babel/eslint-parser
babel/babel#13782v7.16.0
@rushstack/eslint-patch
(Support ESLint 8.x microsoft/rushstack#2890)v1.0.8
@typescript-eslint/eslint-plugin
(Support for ESLint v8 typescript-eslint/typescript-eslint#3738)meta.docs.category
from rules typescript-eslint/typescript-eslint#3800PrivateIdentifier
typescript-eslint/typescript-eslint#3808v5.0.0
@typescript-eslint/parser
(Support for ESLint v8 typescript-eslint/typescript-eslint#3738)meta.docs.category
from rules typescript-eslint/typescript-eslint#3800PrivateIdentifier
typescript-eslint/typescript-eslint#3808v5.0.0
eslint-plugin-flowtype
(Support ESLint 8.x gajus/eslint-plugin-flowtype#495)v8.0.0
eslint-plugin-import
(Support ESLint 8.x import-js/eslint-plugin-import#2211)v2.25.0
eslint-plugin-jest
(Support ESLint 8.x jest-community/eslint-plugin-jest#881)hasSuggestion
for ESLint v8 jest-community/eslint-plugin-jest#898hasSuggestions
rather thanhasSuggestion
jest-community/eslint-plugin-jest#899eslint@8
jest-community/eslint-plugin-jest#940@typescript-eslint/experimental-utils
to v5 jest-community/eslint-plugin-jest#941@typescript-eslint/eslint-plugin@5
jest-community/eslint-plugin-jest#942v24.4.1
v24.4.2
v25.0.0
v25.0.4
v25.0.5
v25.1.0
eslint-plugin-jsx-a11y
(Support ESLint 8.x jsx-eslint/eslint-plugin-jsx-a11y#809)v6.5.0
eslint-plugin-react
(Support ESLint 8.x jsx-eslint/eslint-plugin-react#3055)v7.27.0
eslint-plugin-react-hooks
([eslint-plugin-react-hooks] Support ESLint 8.x react#22246)v4.3.0
eslint-plugin-testing-library
(Support ESLint 8.x testing-library/eslint-plugin-testing-library#462)v5.0.0
Dependencies for
react-scripts
should be compatible with ESLint 8 too before we can merge this one:eslint-webpack-plugin
(Support ESLint 8.x webpack-contrib/eslint-webpack-plugin#118)v3.1.0
Closes #11374
BREAKING CHANGE: Requires ESLint@^8.0.0