Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set java version in verifybuild.yml #1275

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mitrok-Bit
Copy link

@Mitrok-Bit Mitrok-Bit commented Oct 19, 2024

We are using the latest version of Ubuntu to run our github actions. The default java version is now becoming 17 in the newest version of ubuntu, yet our sdk runs using java 11. Therefore, we should explicitly set the java version.

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • sign contributor license agreement
  • I've ensured that all existing tests pass and added tests (when/where necessary)
  • I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Describe what you accomplished in this pull request (for example, what happens before the change, and after the change)

Test Plan

Test Plan: Add your test plan here

We are using the latest version of Ubuntu to run our github actions. The default java version is now becoming 17 in the newest version of ubuntu, yet our sdk runs using java 11. Therefore, we should explicitly set the java version.
@facebook-github-bot
Copy link
Contributor

Hi @Mitrok-Bit!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Author

@Mitrok-Bit Mitrok-Bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants