-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AsyncFdSocket.h: fix for macOS < 11 #2124
base: main
Are you sure you want to change the base?
Conversation
I really need this patch on my MacOS 10.15.x machine, otherwise I have to buy a new machine to develop on :| I am unfamiliar with folly or brew and how to patch brew packages. Does rpm-build:fedora-rawhide-* build anyway ? |
I think the rpm-build:fedora-rawhide-* issue is nothing to do with with this issue ! Looks like its a failed patch in a test specific to rpm-build:fedora-rawhide ! https://github.com/facebook/folly/blob/main/folly/executors/test/CodelTest.cpp
|
If Macports is an acceptable solution for you, the patch is already there.
Sorry, I have no idea, I do not use Linux. |
@barracuda156 - Sorry for my ignorance I am not a Mac person, how do I about obtaining those ? Ah okay its an alternative to brew, okay will try, thanks !
I am a seasoned Linux and ex Fedora user, but needs to be attended to by someone who knows the specific area. |
On a macOS, you could install |
@barracuda156 - Great, I am going to move over to MacPorts most likely. I got watchman installed using it that uses folly. Just need to see what its node.js support is like. |
a6a1155
to
b345eea
Compare
Interesting! I think we can do something like this. I would like to avoid changing preprocessor symbol definitions not owned by folly. What we can do is |
Fixes: #2099
Credits to @sryze for pointing out the cause of the breakage in #2031 (comment)
However, the problem is not specific to Catalina, but affects every macOS from 10.15 down to 10.5, and of course the solution is not to hack the SDK, but provide a fix in the code.