Traits.h: Fix feature-test macro for P1144 trivial relocatability #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well, this is awkward. facebook#2216 added this `#if` check, but with the wrong macro: `__cpp_lib_is_trivially_relocatable` should have been `__cpp_lib_trivially_relocatable`.
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this is awkward. #2216 added this
#ifcheck, but with the P1144 macro typo'ed:__cpp_lib_is_trivially_relocatableshould have been__cpp_lib_trivially_relocatable.In #2216 I even pointed to both the proposal and another repo's (correct) example, and yet somehow I still typo'ed it in the actual PR, and didn't notice for months! Really sorry about this.
Compiler Explorer (left-hand pane: as it is today; right-hand pane: with the wrong macro manually defined so that you get the codegen you were supposed to be getting all along)
https://godbolt.org/z/7oP3Yz61d
Attn: @Orvid, @ot