BugFix: Prevent insertion of link of collapsed selection

[bhavyakaria]

fix: #5305

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 23, 2024 5:10am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 23, 2024 5:10am

[bhavyakaria]

@acywatson wanted your comments on the following behaviour, is this expected?

Current Behaviour

• Select text
• Click on insert link button
• Default link with https:// gets created and then user has to click on edit icon to update the link

Shouldn't on clicking insert link button, it should be showing the edit view where user directly inserts the link and saves?Rather than having to clink on edit button to insert the link.

Attached the video for reference

Screen.Recording.2023-12-07.at.3.15.53.AM.mov

[acywatson]

Shouldn't on clicking insert link button, it should be showing the edit view where user directly inserts the link and saves?Rather than having to clink on edit button to insert the link.

Yes - the way it currently works is the most annoying thing in the entire playground app to me. You are welcome to change it in a different PR.

[ivailop7]

Leaving to @acywatson on how to proceed with this one.

[acywatson]

Leaving to @acywatson on how to proceed with this one.

Looks like we have a failing test to fix. Make sure it's not causing a regression.

[acywatson]

See comment re: test

[bhavyakaria]

@acywatson a bit late but have fixed the UT 😅

[ivailop7]

This introduces an issue where if try to remove an existing link when my collapsed selection is in inside the link, it blocks the toggling off of the link.

[bhavyakaria]

@ivailop7 thanks for pointing out, will fix it

[bhavyakaria]

@ivailop7 Have fixed the delete link issue.