When creating a new check list, set the checked value of the list item to false instead of undefined
#5978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanharwara
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
potatowagon
reviewed
Apr 29, 2024
| const listItem = $createListItemNode(); | ||
| const listItem = $createListItemNode( | ||
| listType === 'check' ? false : undefined, | ||
| ); |
There was a problem hiding this comment.
wondering if its more appropriate to make the handling of this behaviour clearer inside packages/lexical-list/src/LexicalListItemNode.ts
There was a problem hiding this comment.
how about now? i've refactored LexicalListItemNode.getChecked() to always return a boolean if the parent list type is "check" and undefined otherwise.
|
packages/lexical-playground/tests/e2e/List.spec.mjs:1170:3 › Nested List › Can create check list, toggle it to bullet-list and back is breaking |
size-limit report 📦
|
…pe changes to bullet or number
|
Sorry for the long delay. Should be fixed now. |
etrepum
approved these changes
Aug 4, 2024
jkjk822
pushed a commit
to jkjk822/lexical
that referenced
this pull request
Aug 26, 2024
…tem to `false` instead of `undefined` (facebook#5978)
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, when creating a new checklist, the newly created list item doesn't have the
checkedset until the user manually toggles it. This PR makes sure that thecheckedvalue is set tofalseand notundefined.This also makes the behavior in line with the behavior when creating a check list using the markdown transformer.
lexical-checklist.mp4