Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-devtools] Feature: Reflect picker state on inspector button ui #6077

Merged
merged 7 commits into from
May 15, 2024

Conversation

2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented May 10, 2024

Description

EditorInspectorButton reflects pickerActive state on UI.

Closes: #6068

Test plan

Before

2024-05-10.6.36.16.mov

After

2024-05-10.6.33.59.mov

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 11:13pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 11:13pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 10, 2024
@2wheeh 2wheeh changed the title [lexical-devtools] Reflect picker state on inspector button ui [lexical-devtools] Feature: Reflect picker state on inspector button ui May 12, 2024
Copy link
Contributor

@StyleT StyleT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for this contribution!

Do you think it's possible to implement this via ExtensionStore instead of a bit quirky way when we try to keep sync via pending promise?

Also if done via store - we can sync that state to popup window as well easy peasy, while current approach makes it impossible

@2wheeh
Copy link
Contributor Author

2wheeh commented May 14, 2024

@StyleT Thanks ! I reverted and changed to utilize store. Please check the last commit

@2wheeh 2wheeh requested a review from StyleT May 14, 2024 02:15
Copy link
Contributor

@StyleT StyleT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now!

packages/lexical-devtools/src/store.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@StyleT StyleT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@StyleT StyleT added this pull request to the merge queue May 14, 2024
@StyleT StyleT added the extended-tests Run extended e2e tests on a PR label May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 14, 2024
@StyleT StyleT added this pull request to the merge queue May 15, 2024
Merged via the queue into facebook:main with commit 94c44f4 May 15, 2024
47 checks passed
@2wheeh 2wheeh deleted the picker-state-on-ui branch May 16, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants