Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Feature: Apply indent value from theme on exporting paragraphNode #6083

Closed
wants to merge 3 commits into from
Closed

[WIP] Feature: Apply indent value from theme on exporting paragraphNode #6083

wants to merge 3 commits into from

Conversation

2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented May 11, 2024

Description

Now, exportDOM of paragraphNode applies indent value that is configured from theme and also has indent class.
So we get more similar html generated to dom created by reconciler.

Closes: #6082

Test plan

Before

Insert relevant screenshots/recordings/automated-tests

After

Insert relevant screenshots/recordings/automated-tests

@vercel Vercel
Copy link

vercel bot commented May 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 7:36am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 7:36am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 11, 2024
@2wheeh
Copy link
Contributor Author

2wheeh commented May 11, 2024

It seems to be set considering to pasting html which has 20px of base indent size...
It's not as simple as i expected.
Closing this for now.

@2wheeh 2wheeh closed this May 11, 2024
@2wheeh 2wheeh deleted the apply-indent-from-theme-on-exported branch August 30, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx will be requested when the pull request is marked ready for review zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka will be requested when the pull request is marked ready for review fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson will be requested when the pull request is marked ready for review acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz will be requested when the pull request is marked ready for review Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 will be requested when the pull request is marked ready for review ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm will be requested when the pull request is marked ready for review Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon will be requested when the pull request is marked ready for review potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2wheeh @facebook-github-bot