[lexical-playground][lexical-react][lexical] Feature: Theme class added to horizontal rule node #6090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daltnd
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
StyleT
reviewed
May 13, 2024
| return document.createElement('hr'); | ||
| createDOM(config: EditorConfig): HTMLElement { | ||
| const element = document.createElement('hr'); | ||
| addClassNamesToElement(element, config.theme.hr); |
There was a problem hiding this comment.
nit: I think it's better to use getCachedClassNameArray(config.theme, 'hr') here as it runs normalizeClassNames fn against classes
There was a problem hiding this comment.
Happy to do that. It looks like getCachedClassNameArray is only in the lexicalUtils file, though, so the import would dig into lexical/src:
import {getCachedClassNameArray} from 'packages/lexical/src/LexicalUtils';
Would it be better to move that function to the @lexical/utils package or is that import ok?
There was a problem hiding this comment.
I think you can't move it to @lexical/utils as lexical can't depend on @lexical/utils...
Mmm, I think we can keep it as is :)
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds theme class support to
HorizontalRuleNodeso that it can be targeted from the theme object in the editor config instead of through CSS workarounds. Theselectedclass is still added/removed upon selecting the HR node and relevant tests have been updated to include the theme class.Closes: #4336