Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@lexical/devtools] Bug Fix: Reduce requested permissions as we don't use them atm #6099

Merged
merged 1 commit into from
May 13, 2024

Conversation

StyleT
Copy link
Contributor

@StyleT StyleT commented May 13, 2024

Description

Reduce requested permissions as we don't use scripting or storage atm. This is a blocker to submit extension to the Chrome Webextension Store

Test plan

Manual regression was done here, E2E tests to be created as a part of the extension project.

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 6:09pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 6:09pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2024
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.93 KB (0%) 479 ms (0%) 491 ms (+5.23% 🔺) 970 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.56 KB (0%) 692 ms (0%) 1.2 s (-15.04% 🔽) 1.9 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.51 KB (0%) 691 ms (0%) 1.1 s (-12.69% 🔽) 1.7 s

@StyleT StyleT marked this pull request as ready for review May 13, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants