[lexical-markdown] Breaking Change: rename 'multilineElement' to 'multiline-element' #6617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potatowagon
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7 and
Sahejkm
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
potatowagon
commented
Sep 10, 2024
| @@ -432,7 +432,7 @@ export function transformersByType(transformers: Array<Transformer>): Readonly<{ | |||
|
|
|||
| return { | |||
| element: (byType.element || []) as Array<ElementTransformer>, | |||
| multilineElement: (byType.multilineElement || | |||
| multilineElement: (byType['multiline-element'] || | |||
There was a problem hiding this comment.
im not sure of the historical reason why kebab case was originally chosen as the type name convention.
im open to switching everything to lowerCamelCase if theres a compelling reason
etrepum
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
to be consistent with other types like
text-match,text-formatTest plan
see automated tests