[lexical-react] Refactor: Ensure disconnect is called after connection is established in useYjsCollaboration

[smworld01]

connect can be an asynchronous function, and we don't take this into account when disconnecting, meaning that it is possible to disconnect without completing the connect.
I think this can lead to various side effects, such as being disconnected but still in the connect state.

In my case, this happened in React.StrictMode, which is a bit unusual.

It's a simple code change, so I don't think test code is necessary.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 11, 2024 6:06pm
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 11, 2024 6:06pm

[facebook-github-bot]

Hi @smworld01!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[github-actions]

size-limit report 📦

Path	Size
lexical - cjs	29.77 KB (0%)
lexical - esm	29.6 KB (0%)
@lexical/rich-text - cjs	38.24 KB (0%)
@lexical/rich-text - esm	31.46 KB (0%)
@lexical/plain-text - cjs	36.82 KB (0%)
@lexical/plain-text - esm	28.86 KB (0%)
@lexical/react - cjs	40.01 KB (0%)
@lexical/react - esm	32.93 KB (0%)

[etrepum]

There is a timing difference between Promise.resolve(undefined).then(f) and f() because the former executes during the next microtask, but I think generally speaking that should be fine unless someone has some overly sensitive unit tests.

I guess if someone really did need the existing timing behavior they could use something like:

// undefined when connected
let connectingPromise: Promise<undefined> | undefined = connect()?.then(() => {
  connectingPromise = undefined;
});

connectingPromise?.then(() => disconnect()) ?? disconnect();