[lexical-code] Bug Fix: Annotate @lexical/code as having side-effects for Prism #6652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
added
extended-tests
size-limit report 📦
|
facebook-github-bot
added
the
CLA Signed
etrepum
force-pushed
the
lexical-code-fix
branch
from
d6a56f3
to
786f2b0
Compare
potatowagon
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change in #6562 appears to have triggered an issue with astro's rollup configuration which will treeshake Prism out of @lexical/code, since it is only an import side-effect. Marking the package.json as having sideEffects is sufficient to fix it.
Note that #6650 currently has this commit included so the integration tests pass, but I made it a separate PR in case we want to review/merge separately.
Test plan
Before
Integration tests in #6650 were failing
After
Integration tests pass