[lexical-markdown] Feature: add ability to hook into the import process for multiline element transformers #6682
+32
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ElementTransformer
AlessioGr
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
potatowagon
reviewed
Oct 2, 2024
| * | ||
| * @returns a tuple or null. The first element of the returned tuple is a boolean indicating if a multiline element was imported. The second element is the index of the last line that was processed. If null is returned, the next multilineElementTransformer will be tried. If undefined is returned, the default behavior will be used. | ||
| */ | ||
| handleImportAfterStartMatch?: (args: { |
There was a problem hiding this comment.
looks safe since this is optional, wdyt about adding a test case to demo a simple usecase of this fn?
potatowagon
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is similar to #6681 but for multiline element transformers.
This adds a new
handleImportAfterStartMatchproperty toMultilineElementTransformerthat allows you to replace whatever happens after theregExpStarthas matched with your own, custom logic.This is great for cases where the default logic for finding the end of a given match and running the
replacefunction is not enough.E.g. for JSX elements, we need custom logic to keep track of the amount of opened and closed tags matched in order to find the correct, ending tag. Simply looking for the next closing tag using
regExpEndwould not work for nested JSX elements. (Example of this in action)