Simplify symlink handling #1398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66899343 |
|
This pull request was exported from Phabricator. Differential Revision: D66899343 |
robhogan
added a commit
that referenced
this pull request
Dec 10, 2024
Summary: Pull Request resolved: #1398 Reading symlink targets with `readLink` is currently delegated to `metro-file-map`'s worker abstraction. However, due to the way the abstraction is used for symlinks, we never actually use the worker processes/threads, and always process in band. The key here is that `readLink` is always mutually exclusive with other worker tasks, like `computeSha1` and `computeDependencies` - as it must be, because those operations don't make sense for symlink files. This lifts the call to `readLink` out of the abstraction and explicitly into the main process, simplifying the worker and improving readability. Changelog: Internal Differential Revision: D66899343
robhogan
force-pushed
the
export-D66899343
branch
from
a672bef to
2f12fc9
Compare
robhogan
added a commit
that referenced
this pull request
Dec 11, 2024
Summary: Reading symlink targets with `readLink` is currently delegated to `metro-file-map`'s worker abstraction. However, due to the way the abstraction is used for symlinks, we never actually use the worker processes/threads, and always process in band. The key here is that `readLink` is always mutually exclusive with other worker tasks, like `computeSha1` and `computeDependencies` - as it must be, because those operations don't make sense for symlink files. This lifts the call to `readLink` out of the abstraction and explicitly into the main process, simplifying the worker and improving readability. Changelog: Internal Differential Revision: D66899343
robhogan
force-pushed
the
export-D66899343
branch
from
2f12fc9 to
b7f07cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66899343 |
Summary: Reading symlink targets with `readLink` is currently delegated to `metro-file-map`'s worker abstraction. However, due to the way the abstraction is used for symlinks, we never actually use the worker processes/threads, and always process in band. The key here is that `readLink` is always mutually exclusive with other worker tasks, like `computeSha1` and `computeDependencies` - as it must be, because those operations don't make sense for symlink files. This lifts the call to `readLink` out of the abstraction and explicitly into the main process, simplifying the worker and improving readability. Changelog: Internal Differential Revision: D66899343
robhogan
force-pushed
the
export-D66899343
branch
from
b7f07cc to
8be0030
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66899343 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
Summary: Reading symlink targets with `readLink` is currently delegated to `metro-file-map`'s worker abstraction. However, due to the way the abstraction is used for symlinks, we never actually use the worker processes/threads, and always process in band. The key here is that `readLink` is always mutually exclusive with other worker tasks, like `computeSha1` and `computeDependencies` - as it must be, because those operations don't make sense for symlink files. This lifts the call to `readLink` out of the abstraction and explicitly into the main process, simplifying the worker and improving readability. Changelog: Internal Differential Revision: D66899343
|
This pull request was exported from Phabricator. Differential Revision: D66899343 |
|
This pull request has been merged in 91e5dfc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reading symlink targets with
readLinkis currently delegated tometro-file-map's worker abstraction. However, due to the way the abstraction is used for symlinks, we never actually use the worker processes/threads, and always process in band.The key here is that
readLinkis always mutually exclusive with other worker tasks, likecomputeSha1andcomputeDependencies- as it must be, because those operations don't make sense for symlink files.This lifts the call to
readLinkout of the abstraction and explicitly into the main process, simplifying the worker and improving readability.Changelog: Internal
Differential Revision: D66899343