metro-file-map: Extract mocks handling into nullable MockMap #1402
+152
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Reading symlink targets with `readLink` is currently delegated to `metro-file-map`'s worker abstraction. However, due to the way the abstraction is used for symlinks, we never actually use the worker processes/threads, and always process in band. The key here is that `readLink` is always mutually exclusive with other worker tasks, like `computeSha1` and `computeDependencies` - as it must be, because those operations don't make sense for symlink files. This lifts the call to `readLink` out of the abstraction and explicitly into the main process, simplifying the worker and improving readability. Changelog: Internal Differential Revision: D66899343
Summary: Extract almost all mock handling logic out of `FileMap` and into `MockMap`. Mocks are obviously a Jest concept inherited from `jest-haste-map`, but we're keeping them around in `metro-file-map` for planned re-use of `metro-file-map` as a custom `hasteMapModulePath` in Jest, at least at Meta. This is a step towards making `MockMap` into a *plugin* or subscriber to `FileMap`, so that we don't need to keep it in `metro-file-map`'s codebase and can inject it where needed. Changelog: Internal (No Metro-user-facing change, `metro-file-map`'s API is [explicitly experimental](https://github.com/facebook/metro/tree/main/packages/metro-file-map#experimental-metro-file-map)) Test Plan: - New unit tests - `mocksPattern` is always `null` in Metro, so the new code isn't reached right now, except by tests. - We'll exercise this code next half when we use it in a Jest context. Differential Revision: D67056483 Pulled By: robhogan
facebook-github-bot
force-pushed
the
feat/mock-map-2
branch
from
3125d6d to
664c5d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67056483 |
robhogan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extract almost all mock handling logic out of
FileMapand intoMockMap.Mocks are obviously a Jest concept inherited from
jest-haste-map, but we're keeping them around inmetro-file-mapfor planned re-use ofmetro-file-mapas a customhasteMapModulePathin Jest, at least at Meta.This is a step towards making
MockMapinto a plugin or subscriber toFileMap, so that we don't need to keep it inmetro-file-map's codebase and can inject it where needed.Changelog: Internal
(No Metro-user-facing change,
metro-file-map's API is explicitly experimental)Test plan
mocksPatternis alwaysnullin Metro, so the new code isn't reached right now, except by tests.