FSEventsWatcher: use common recReadDir #1409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Minor Flow type refinement - I originally typed this as `?(boolean | RegExp)` when conservatively adding types to untyped JS. In fact we only ever pass `?RegExp`, so we can tidy up a bit. Changelog: Internal Differential Revision: D67285745
Summary: `FSEventsWatcher` has its own implementation of `recReaddir` which is almost identical to the one in `./common.js`, except that it wraps handlers in `path.normalize`. There’s only one handler, so we can trivially remove this proxy abstraction and reuse the common `recReaddir`. (The end goal here is to slim down and tidy up FSEventsWatcher ahead of using it as a basis for native recursive watching) Changelog: Internal Differential Revision: D67286092
facebook-github-bot
added
the
CLA Signed
|
This pull request has been merged in 6d2ccbf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
FSEventsWatcherhas its own implementation ofrecReaddirwhich is almost identical to the one in./common.js, except that it wraps handlers inpath.normalize.There’s only one handler, so we can trivially remove this proxy abstraction and reuse the common
recReaddir.(The end goal here is to slim down and tidy up FSEventsWatcher ahead of using it as a basis for native recursive watching)
Changelog: Internal
Differential Revision: D67286092