Add auto-deriving functions for TaintAccessPath.t

Summary: So that `TaintAccessPath.t` can be used in `target.ml` to define parameterized callables in the follow-ups. Reviewed By: arthaud Differential Revision: D64152389 fbshipit-source-id: b4ad977842da3561180da42d5d69b29e5af3fd1c
facebook · Oct 11, 2024 · 88ddcf8 · 88ddcf8
1 parent 4dae77a
commit 88ddcf8
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 6 deletions.
diff --git a/source/domains/abstractTreeDomain.ml b/source/domains/abstractTreeDomain.ml
@@ -115,11 +115,13 @@ module StringSet = Set.Make (String)
 
 module Label = struct
   module T = struct
+    open Core
+
     type t =
       | AnyIndex
       | Index of string
       | Field of string
-    [@@deriving ord, eq]
+    [@@deriving ord, eq, sexp, hash]
 
     type path = t list
   end

diff --git a/source/domains/abstractTreeDomain.mli b/source/domains/abstractTreeDomain.mli
@@ -28,7 +28,7 @@ module Label : sig
     | AnyIndex
     | Index of string
     | Field of string
-  [@@deriving show, eq]
+  [@@deriving show, eq, sexp, hash]
 
   type path = t list [@@deriving show]
 

diff --git a/source/domains/dune b/source/domains/dune
@@ -2,5 +2,11 @@
  (name abstract)
  (public_name pyrelib.domains)
  (preprocess
-  (pps ppx_deriving.eq ppx_deriving.show ppx_deriving.ord))
+  (pps
+   ppx_deriving.eq
+   ppx_deriving.show
+   ppx_deriving.ord
+   ppx_hash
+   ppx_sexp_conv
+   ppx_sexp_message))
  (libraries core ppx_deriving))
diff --git a/source/interprocedural/taintAccessPath.ml b/source/interprocedural/taintAccessPath.ml
@@ -207,7 +207,7 @@ let normalize_parameters parameters =
 
 
 module Path = struct
-  type t = Abstract.TreeDomain.Label.t list
+  type t = Abstract.TreeDomain.Label.t list [@@deriving compare, sexp, hash]
 
   let pp = Abstract.TreeDomain.Label.pp_path
 
@@ -373,7 +373,7 @@ type t = {
   root: Root.t;
   path: Path.t;
 }
-[@@deriving compare]
+[@@deriving compare, eq, sexp, hash]
 
 let pp formatter { root; path } = Format.fprintf formatter "%a%a" Root.pp root Path.pp path
 

diff --git a/source/interprocedural/taintAccessPath.mli b/source/interprocedural/taintAccessPath.mli
@@ -70,7 +70,7 @@ type t = {
   root: Root.t;
   path: Path.t;
 }
-[@@deriving compare]
+[@@deriving compare, eq, sexp, hash]
 
 val pp : Format.formatter -> t -> unit