Clean up errors and remove unused ignores] [batch:26/554] [shard:3/N]

Reviewed By: MaggieMoss Differential Revision: D64651939 fbshipit-source-id: e5a7d56e65b5ade3d89cd374531bfdda662dbb27
facebook · Oct 22, 2024 · d028dab · d028dab
1 parent fa94e18
commit d028dab
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 7 deletions.
diff --git a/client/commands/profile.py b/client/commands/profile.py
@@ -45,7 +45,6 @@ class EventMetadata:
 
 
 @dataclasses.dataclass(frozen=True)
-# pyre-fixme[13]: Attribute `metadata` is never initialized.
 class Event:
     # pyre-fixme[13]: Attribute `metadata` is never initialized.
     metadata: EventMetadata

diff --git a/scripts/compare_pysa_models_to_json.py b/scripts/compare_pysa_models_to_json.py
@@ -225,7 +225,6 @@ def get_attribute_model_from_line(line: str) -> Optional[Tuple[str, TargetModel]
         for annotation in annotation_match.group("model_leaves").split(", ")
     }
     if model_type == "sources":
-        # pyre-fixme[26]: TypedDict key must be a string literal.
         result["return_model"][model_type].update(attribute_model_leaves)
     else:
         result["parameters"]["$global"][

diff --git a/tools/generate_taint_models/get_dynamic_graphql_sources.py b/tools/generate_taint_models/get_dynamic_graphql_sources.py
@@ -66,7 +66,6 @@ def compute_models(
                 continue
 
             try:
-                # pyre-fixme[16]: `GraphQLNamedType` has no attribute `fields`.
                 fields = element.fields
                 gql_object_name = element.name
             except AssertionError:

diff --git a/tools/generate_taint_models/inspect_parser.py b/tools/generate_taint_models/inspect_parser.py
@@ -30,8 +30,6 @@
 
 def extract_qualified_name(callable_object: Callable[..., object]) -> Optional[str]:
     if inspect.ismethod(callable_object):
-        # pyre-fixme[6]: Expected `(...) -> object` for 1st param but got
-        #  `_StaticFunctionType`.
         return extract_qualified_name(callable_object.__func__)
     else:
         module_name = getattr(callable_object, "__module__", None)
@@ -55,7 +53,6 @@ def extract_parameters(
     if isinstance(callable_object, types.FunctionType):
         callable_parameters = inspect.signature(callable_object).parameters
     elif isinstance(callable_object, types.MethodType):
-        # pyre-ignore: Too dynamic
         callable_parameters = inspect.signature(callable_object.__func__).parameters
 
     parameters: List[Parameter] = []

diff --git a/tools/generate_taint_models/tests/get_models_filtered_by_callable_test.py b/tools/generate_taint_models/tests/get_models_filtered_by_callable_test.py
@@ -22,7 +22,6 @@ def __eq__(self, other: "TestModel") -> int:
 
     # pyre-fixme[7]: Expected `int` but got implicit return value of `None`.
     def __hash__(self) -> int:
-        # pyre-fixme[7]: Expected `int` but got implicit return value of `None`.
         pass
 
     def __str__(self) -> str: