-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use Hermes Sampling Profiler API for JS Samplings (#48315)
Summary: # Changelog: [Internal] Use newly added API to Hermes. In terms of Trace Events, we are going to emit: - An event for Process metadata, which will be named "Hermes" - An event for Thread metadata, on which Hermes runs - Complete Trace Event for the same Thread, which is required track to appear in the Timeline UI. I believe duration field is the key for this - Trace Event for Profile - Trace Event for ProfileChunk, which contains information about nodes and the callstack tree representation > Important: current implementation emits single ProfileChunk event. I didn't notice any issues in terms of JSON bandwidth while recording 1 minute long session in CPU-heavy application. We should re-evaluate this decision in the future and split Profiles into multiple chunks. Differential Revision: D67353586
- Loading branch information
1 parent
4dac99c
commit d2ab914
Showing
2 changed files
with
147 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters