-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh check_buck_targets.sh #13196
Refresh check_buck_targets.sh #13196
Conversation
@mszeszko-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix this so that it fails if the BUCK file goes missing?
@mszeszko-meta has updated the pull request. You must reimport the pull request before landing. |
3bcee43
to
f34cbd8
Compare
@mszeszko-meta has updated the pull request. You must reimport the pull request before landing. |
@mszeszko-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@mszeszko-meta has updated the pull request. You must reimport the pull request before landing. |
@mszeszko-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@mszeszko-meta has updated the pull request. You must reimport the pull request before landing. |
@mszeszko-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
3138650
to
b4af0b9
Compare
@mszeszko-meta has updated the pull request. You must reimport the pull request before landing. |
@mszeszko-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
@mszeszko-meta merged this pull request in bfe6cc2. |
Summary:
This is a followup to #13190. We're patching the targets generating script to construct
BUCK
file instead of deprecatedTARGETS
file + adding safety checks to ensure thatBUCK
file does not go missing (either as a direct renaming / removal OR as a modification to buckfier's script(s)).Test plan:
-> Simulate removing
BUCK
file via commit-> Simulate buckifier script removing the
BUCK
file